Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] experimental search backport #5221

Merged
merged 5 commits into from
Dec 13, 2022
Merged

[full-ci] experimental search backport #5221

merged 5 commits into from
Dec 13, 2022

Conversation

fschade
Copy link
Contributor

@fschade fschade commented Dec 12, 2022

Description

Experimental search backport.
Some parts still missed like Tags and async file indexing.

It contains the following improvements:

  • content extraction, search now supports apache tika to extract resource contents.
  • search engine, underlying search engine is swappable now.
  • event consumers, the number of event consumers can now be set, which improves the speed of the individual tasks

Related Issue

How Has This Been Tested?

  • unit tests
  • acceptance tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • Code changes
  • Unit tests added
  • [-] Acceptance tests added
  • [-] Documentation ticket raised:

@fschade fschade mentioned this pull request Dec 12, 2022
Closed
@fschade fschade changed the title experimental search backport [full-ci] experimental search backport Dec 12, 2022
C0rby
C0rby reviewed Dec 12, 2022
View reviewed changes
services/search/pkg/config/defaults/defaultconfig.go Outdated Show resolved Hide resolved
services/search/pkg/content/cs3.go Outdated Show resolved Hide resolved
services/search/pkg/content/cs3.go Outdated Show resolved Hide resolved
services/search/pkg/content/tika.go Outdated Show resolved Hide resolved
services/search/pkg/engine/bleve.go Outdated Show resolved Hide resolved
services/search/pkg/engine/engine.go Outdated Show resolved Hide resolved
@fschade
fix basic extractor resource name
d7ae6b2 
move escapeQuery regex into global variable
minor pr review changes
@fschade fschade marked this pull request as ready for review December 13, 2022 10:15
aduffeck
aduffeck requested changes Dec 13, 2022
View reviewed changes
services/search/pkg/config/search.go Outdated Show resolved Hide resolved
services/search/pkg/engine/bleve.go Show resolved Hide resolved
services/search/pkg/engine/engine.go Outdated Show resolved Hide resolved
@fschade fschade mentioned this pull request Dec 13, 2022
Closed
25 tasks
@fschade
rename DebounceDuration env variable
481d67c 
add document title and content when rebuilding bleve resource
@sonarcloud
Copy link

sonarcloud bot commented Dec 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 17 Code Smells

65.0% 65.0% Coverage
0.0% 0.0% Duplication

aduffeck
aduffeck approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@aduffeck aduffeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fschade fschade merged commit 2404eff into master Dec 13, 2022
@delete-merged-branch delete-merged-branch bot deleted the search-experimental-to-master branch December 13, 2022 13:22
ownclouders pushed a commit that referenced this pull request Dec 13, 2022
@fschade
commit 2404eff
8c55d3a 
Author: Florian Schade <f.schade@icloud.com>
Date:   Tue Dec 13 14:22:41 2022 +0100

    [full-ci] experimental search backport (#5221)

    * experimental search backport
    fix basic extractor resource name
    move escapeQuery regex into global variable
    minor pr review changes
    rename DebounceDuration env variable
    add document title and content when rebuilding bleve resource

    Co-authored-by: David Christofas <dchristofas@owncloud.com>
wkloucek added a commit to owncloud/ocis-charts that referenced this pull request Jan 27, 2023
@wkloucek
add configuration for search extractor, needs owncloud/ocis#5221
19ff9d6
@wkloucek wkloucek mentioned this pull request Jan 27, 2023
Merged
5 tasks
wkloucek added a commit to owncloud/ocis-charts that referenced this pull request Feb 13, 2023
@wkloucek
add configuration for search extractor, needs owncloud/ocis#5221
7a65f29
wkloucek added a commit to owncloud/ocis-charts that referenced this pull request Mar 9, 2023
@wkloucek
add configuration for search extractor, needs owncloud/ocis#5221
346e987
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C0rby C0rby C0rby approved these changes

@aduffeck aduffeck aduffeck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fschade @aduffeck @C0rby